Suggest use .. to fill in the rest of the fields of Struct #103012

chenyukang · 2022-10-13T15:37:34Z

Fixes #102806

rustbot · 2022-10-13T15:37:38Z

rustc_error_messages was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki

rust-highfive · 2022-10-13T15:37:38Z

r? @eholk

(rust-highfive has picked a reviewer for you, use r? to override)

compiler/rustc_parse/src/parser/expr.rs

compiler-errors · 2022-10-14T02:20:20Z

compiler/rustc_parse/src/parser/expr.rs

+                self.bump();
+                match self.parse_expr() {
+                    Ok(_p) => {
+                        self.sess.emit_err(MissingDotDot { token_span: span, sugg_span: span });


Looking better!

Can you actually set the base expression like above? Something like base = ast::StructRest::Base(e). Basically emulate the code above. That should suppress the "missing fields x and y in initializer of V3" error below.

Also, can handle the case of ... } like above?

oo, I left the "missing fields x and y in initializer of V3" intentionally, I thought it may helpful for let developer know which fields are missing.

And for the case of ...}, we need to suggest something like ..{expr}? So I left it as before also.

I thought it may helpful for let developer know which fields are missing.

This is extra noise if the developer wrote ... instead of .., which is what your PR is trying to fix, right? 😆

And for the case of ...}, we need to suggest something like ..{expr}?

Not in the case of a pattern, which is the same place that .. } is valid.

Basically, we should treat ... typo as closely to .. as possible, especially if we're "recovering" parsing here.

It may actually be easier to merge this check with the .. logic above, since we're basically just duplicating that.

Ok, I will make a update.

For the case of let V3 { z: val, ...} = v, we already have a check to report:

error: expected field pattern, found `...` --> /home/cat/code/rust/src/test/ui/parser/issue-102806.rs:23:22 | 23 | let V3 { z: val, ... } = v; | ^^^ help: to omit remaining fields, use one fewer `.`: `..`

Will keep same as before.

It may actually be easier to merge this check with the .. logic above, since we're basically just duplicating that.

Tried to merge the two checks, but I found split them seems more easy to read.

That's ok, I don't think it's necessary

Finally, merge it with the .. logic above 😁

compiler-errors · 2022-10-14T02:36:54Z

r? @compiler-errors I can take over this review, and seems like @chenyukang almost has this ready 😸

Nilstrieb · 2022-10-23T11:47:44Z

Hi, I've seen you changed some diagnostic structs in your PR. After #103345, the way we refer to fluent messages changed. They are now in a flat namespace with the same identifier as in the fluent file. For example, parser::cool_thing is now parser_cool_thing and parser::suggestion just suggestion.
You should rebase to the latest master and change your fluent message references as described above. Thanks!

…s of Struct

chenyukang · 2022-11-04T05:03:24Z

You should rebase to the latest master and change your fluent message references as described above. Thanks!

Rebased update.
r? @compiler-errors

rustbot · 2022-11-04T05:03:26Z

Could not assign reviewer from: compiler-errors.
User(s) compiler-errors are either the PR author or are already assigned, and there are no other candidates.
Use r? to specify someone else to assign.

Rageking8 · 2022-11-04T05:38:53Z

You should rebase to the latest master and change your fluent message references as described above. Thanks!

Rebased update.
r? @compiler-errors

Should be @rustbot ready to signify the PR is ready for another review and not r?.

Since I saw you doing r? in other PRs where you meant to say you are ready.

chenyukang · 2022-11-04T05:42:32Z

Should be @rustbot ready to signify the PR is ready for another review and not r?.

Thanks for tip 😁.

@rustbot ready

davidtwco

r=me,compiler-errors after one comment

compiler/rustc_parse/src/parser/expr.rs

bors · 2022-11-05T16:21:37Z

@chenyukang: 🔑 Insufficient privileges: Not in reviewers

compiler/rustc_parse/src/parser/expr.rs

compiler-errors · 2022-11-06T02:33:31Z

@bors r=davidtwco,compiler-errors

I hope you didn't mind me renaming the function typo, but I didn't want to delay r+'ing still since I know you have been waiting 😄

bors · 2022-11-06T02:33:33Z

📌 Commit 28d82dd has been approved by davidtwco,compiler-errors

It is now in the queue for this repository.

chenyukang · 2022-11-06T02:50:33Z

@bors r=davidtwco,compiler-errors

I hope you didn't mind me renaming the function typo, but I didn't want to delay r+'ing still since I know you have been waiting 😄

Thanks very much.

…,compiler-errors Suggest use .. to fill in the rest of the fields of Struct Fixes rust-lang#102806

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#103012 (Suggest use .. to fill in the rest of the fields of Struct) - rust-lang#103851 (Fix json flag in bootstrap doc) - rust-lang#103990 (rustdoc: clean up `.logo-container` layout CSS) - rust-lang#104002 (fix a comment in UnsafeCell::new) - rust-lang#104014 (Migrate test-arrow to CSS variables) - rust-lang#104016 (Add internal descriptions to a few queries) - rust-lang#104035 (Add 'closure match' test to weird-exprs.rs.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

bors · 2022-11-06T11:23:16Z

⌛ Testing commit 28d82dd with merge 88935e0...

rust-highfive assigned eholk Oct 13, 2022

rustbot added A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 13, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 13, 2022

compiler-errors reviewed Oct 13, 2022

View reviewed changes

compiler/rustc_parse/src/parser/expr.rs Outdated Show resolved Hide resolved

chenyukang force-pushed the fix-102806 branch from b2eebf6 to 1b1ce40 Compare October 14, 2022 02:05

compiler-errors reviewed Oct 14, 2022

View reviewed changes

rust-highfive assigned compiler-errors and unassigned eholk Oct 14, 2022

compiler-errors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 22, 2022

This comment was marked as resolved.

Sign in to view

fix rust-lang#102806, suggest use .. to fill in the rest of the field…

1e25882

…s of Struct

chenyukang force-pushed the fix-102806 branch from 5600243 to b0cd3d4 Compare November 4, 2022 05:00

chenyukang force-pushed the fix-102806 branch from b0cd3d4 to 38fe8ad Compare November 4, 2022 05:06

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 4, 2022

fake a base to suppress later extra error message

4b77e73

davidtwco approved these changes Nov 4, 2022

View reviewed changes

compiler/rustc_parse/src/parser/expr.rs Outdated Show resolved Hide resolved

chenyukang force-pushed the fix-102806 branch 2 times, most recently from 29a4924 to 4b77e73 Compare November 4, 2022 17:11

compiler-errors reviewed Nov 6, 2022

View reviewed changes

compiler/rustc_parse/src/parser/expr.rs Outdated Show resolved Hide resolved

compiler-errors reviewed Nov 6, 2022

View reviewed changes

compiler/rustc_parse/src/parser/expr.rs Outdated Show resolved Hide resolved

Fix typo

28d82dd

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 6, 2022

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 6, 2022

Rollup merge of rust-lang#103012 - chenyukang:fix-102806, r=davidtwco…

2e08d30

…,compiler-errors Suggest use .. to fill in the rest of the fields of Struct Fixes rust-lang#102806

matthiaskrgr mentioned this pull request Nov 6, 2022

Rollup of 7 pull requests #104041

Closed

matthiaskrgr mentioned this pull request Nov 6, 2022

Rollup of 7 pull requests #104043

Merged

bors merged commit 58f5d57 into rust-lang:master Nov 6, 2022

rustbot added this to the 1.67.0 milestone Nov 6, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Suggest use .. to fill in the rest of the fields of Struct #103012

Suggest use .. to fill in the rest of the fields of Struct #103012

chenyukang commented Oct 13, 2022

rustbot commented Oct 13, 2022

rust-highfive commented Oct 13, 2022

compiler-errors Oct 14, 2022

chenyukang Oct 14, 2022

compiler-errors Oct 14, 2022 •

edited

Loading

compiler-errors Oct 14, 2022

chenyukang Oct 14, 2022

chenyukang Oct 14, 2022

chenyukang Oct 14, 2022

compiler-errors Oct 14, 2022

chenyukang Nov 4, 2022

compiler-errors commented Oct 14, 2022

Nilstrieb commented Oct 23, 2022

This comment was marked as resolved.

chenyukang commented Nov 4, 2022

rustbot commented Nov 4, 2022

Rageking8 commented Nov 4, 2022 •

edited

Loading

chenyukang commented Nov 4, 2022 •

edited

Loading

davidtwco left a comment

bors commented Nov 5, 2022

compiler-errors commented Nov 6, 2022 •

edited

Loading

bors commented Nov 6, 2022

chenyukang commented Nov 6, 2022

bors commented Nov 6, 2022

Suggest use .. to fill in the rest of the fields of Struct #103012

Suggest use .. to fill in the rest of the fields of Struct #103012

Conversation

chenyukang commented Oct 13, 2022

rustbot commented Oct 13, 2022

rust-highfive commented Oct 13, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

compiler-errors Oct 14, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

compiler-errors commented Oct 14, 2022

Nilstrieb commented Oct 23, 2022

This comment was marked as resolved.

chenyukang commented Nov 4, 2022

rustbot commented Nov 4, 2022

Rageking8 commented Nov 4, 2022 • edited Loading

chenyukang commented Nov 4, 2022 • edited Loading

davidtwco left a comment

Choose a reason for hiding this comment

bors commented Nov 5, 2022

compiler-errors commented Nov 6, 2022 • edited Loading

bors commented Nov 6, 2022

chenyukang commented Nov 6, 2022

bors commented Nov 6, 2022

compiler-errors Oct 14, 2022 •

edited

Loading

Rageking8 commented Nov 4, 2022 •

edited

Loading

chenyukang commented Nov 4, 2022 •

edited

Loading

compiler-errors commented Nov 6, 2022 •

edited

Loading